Remove invalid character from phpunit-rules.neon#276
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Cleans up the PHPUnit PHPStan rules configuration by removing an unintended stray character that could break parsing.
Changes:
- Removed an extraneous non-ASCII character from
config/phpunit-rules.neon.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Thanks. Can you add a unit test to catch these in CI? |
- Add GitHub Actions step "Lint Neon" to run vendor/bin/neon-lint config/ - Add nette/neon dependency and composer script "lint-neon" to run the linter - Ensure Neon config files are linted in CI to catch syntax and format errors early
Member
|
Awesome, thank you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
╰─ c phpstan:analyse ─╯ Note: Using configuration file /.../laravel-skeleton/phpstan.neon.dist. In NeonCachedFileReader.php line 45: [_PHPStan_2874a496b\Nette\Neon\Exception] Error while loading /.../laravel-skeleton/vendor/symplify/phpstan-rules/config/phpunit-rules.neon: Unexpected '<new line>' on line 4, column 3.