Repository navigation
Reject property names that start with a NUL byte - #61
Merged
Merged
Conversation
nicolas-grekas
force-pushed
the
nul-property-names
branch
from
September 29, 2026 21:03
55b5735 to
e1eb772
Compare
deepclone_from_array() created properties whose name starts with a NUL byte, which aren't legal PHP: the engine refuses to access them. They're now rejected, eagerly for lazy objects too. An array cast can give such names to a stdClass, which deepclone_to_array() keeps exporting as they are, like serialize(): checking them would cost every stdClass, and more in the polyfill.
nicolas-grekas
force-pushed
the
nul-property-names
branch
from
September 29, 2026 22:07
e1eb772 to
aede6ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deepclone_from_array()created properties whose name starts with a NUL byte, which aren't legal PHP: the engine refuses to access them. They're now rejected.An array cast can give such names to a
stdClass, eg(object) ["\0x" => 1], whichdeepclone_to_array()keeps exporting as they are, likeserialize()does: checking them would cost everystdClass, and much more in the polyfill, which gets the same rejection in symfony/polyfill#712.