Fix prevent default action when use wheel and mouse events. #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Also add a change to allowZoom, allowPan, allowWheel in runtime. so that you can dynamically enable scaling. |
Owner
|
Hello Denis. Sorry for this insane delay. Your changes make sense but could affect quite a lot of behaviour on current implementations. I could set a disclaimer in the readme about them. But I wonder why you would need to override these styles? |
|
hi @sylvaindubus Regards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Sylvain,
I added the PrismaZoom to my webapp and I have an issue when I scroll my page. Scrolling the page does not work if the pointer is over an area that can be zoomed in. This happens because the default action for the wheel is canceled. I propose to override the default action only if the image is scaled.
Thanks