BridgeJS: Unify @JS struct parameter lowering onto the stack ABI - #798
Merged
Conversation
bridgeJSLowerParameter for structs used toJSObject(), so Swift→JS callbacks discarded the stack and JS lift() read garbage. Match arrays: stack-push on lower, and use the same ABI for ImportTS non-optional structs.
kateinoigakukun
marked this pull request as ready for review
August 10, 2026 00:58
krodak
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@JS structbridgeJSLowerParameter()usedtoJSObject()(object-id ABI). Swift→JS callbacks and the rest of the stack ABI expect a stack push + JSstructHelpers.*.lift(). The object-id path pushed then lifted into a JS object, discarded the id, and left the stacks empty for the callback glue — so JS read garbage.This matches arrays/dictionaries: lower = stack push. ImportTS non-optional structs use the same stack ABI (optional structs already did).
Problematic case
Same failure mode for any Swift→JS typed closure that takes a non-optional
@JS struct(e.g. observation payloads). Bool fields were especially misleading: empty-stacki32pops yieldedundefined, andundefined !== 0becametrue.Fix
_BridgedSwiftStruct.bridgeJSLowerParameter()→bridgeJSStackPush()observeVector/mapVectorinClosureSupportTestsTest plan
ClosureSupportTests.testRunJsClosureSupportTests(struct callback params)SwiftStructTests.testSwiftStructInImportedSignature(ImportTS stack unify)