jextract: Support fully qualified type names#576
Merged
ktoso merged 2 commits intoswiftlang:mainfrom Feb 27, 2026
Merged
Conversation
sidepelican
commented
Feb 27, 2026
| } | ||
|
|
||
| let javaType: JavaType = .class(package: nil, name: swiftNominalType.nominalTypeDecl.name) | ||
| let javaType: JavaType = .class(package: nil, name: swiftNominalType.nominalTypeDecl.qualifiedName) |
Contributor
Author
There was a problem hiding this comment.
This is a secondary bug found incidentally🤣
ktoso
reviewed
Feb 27, 2026
Collaborator
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Looks great afaics, thank you!
ktoso
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, types containing a module prefix are not recognized correctly.
This is because it searches for the type including that module name.
By utilizing the symbol table, I will change it so that if a known imported type name appears first, it can be searched by ignoring that part.