Skip to content

refactor(helpers): narrow TB reward table ids to str in get_tb_mission_scores #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarTrepodi merged 1 commit into from
Oct 13, 2026
Merged

refactor(helpers): narrow TB reward table ids to str in get_tb_mission_scores #184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/swgoh_comlink/helpers/_territory_battle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,11 +520,11 @@ def get_tb_mission_scores(
definitions = _select_definitions(territory_battle_definitions, None, tb_id, func_name)
_check_collection("tables", tables, func_name)

wanted = {
zone.get("encounterRewardTableId")
wanted: set[str] = {
table_id
for definition in definitions
for _, zone in _mission_zones(definition)
if zone.get("encounterRewardTableId")
if (table_id := zone.get("encounterRewardTableId"))
}
# 'table' holds every kind of game table; only parse the ones a mission names.
curves: dict[str, list[int]] = {}
Expand Down
Loading