Update sentence in 'Plotting' lesson to improve tone & clarity#706
Open
sadielbartholomew wants to merge 3 commits intoswcarpentry:mainfrom
Open
Update sentence in 'Plotting' lesson to improve tone & clarity#706sadielbartholomew wants to merge 3 commits intoswcarpentry:mainfrom
sadielbartholomew wants to merge 3 commits intoswcarpentry:mainfrom
Conversation
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits. It should be safe to Approve and Run the workflows that need maintainer approval. |
vahtras
reviewed
Nov 18, 2025
Contributor
There was a problem hiding this comment.
How about "just one call" -> "a single call"?
Author
There was a problem hiding this comment.
Good point - if 'just' is indeed a problematic word it is somewhat ironic, though unintentional, I ended up suggesting it in wording to replace use of 'simple'! Will update in a new commit in a moment.
Author
There was a problem hiding this comment.
Resolved in 1d882a2, though I'll let you mark this as formally resolved if you agree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #705, plus add several extra words on the updated sentence to clarify the arguments to use to
plt.plotwhich in my opinion is useful in addition and otherwise only implied i.e. to be picked up by assumption from the example code snippet - strictly a separate issue so added as a separate commit, but might as well raise in this PR (can revert if controversial but doubt it will be so!).Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.
Update the episode/lesson 'Plotting' to avoid use of the subjective term 'simple', by replacing with the more specific and objective assertion on conciseness, with (whilst touching that sentence) a very small amount of text added to clarify what arguments
plt.plottakes.If any relevant discussions have taken place elsewhere, please provide links to these.
n/a