Update 02-variables.md upper-lower case change#668
Open
teresa-m wants to merge 1 commit intoswcarpentry:mainfrom
Open
Update 02-variables.md upper-lower case change#668teresa-m wants to merge 1 commit intoswcarpentry:mainfrom
teresa-m wants to merge 1 commit intoswcarpentry:mainfrom
Conversation
Thanks a lot for the great learning materials. I have one suggestion. The original statement upper-case letters are the conventions so we use lower case is ambiguous. I guess this was just mixed up, but if not this would need further explanation in my opinion.
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits. It should be safe to Approve and Run the workflows that need maintainer approval. |
Contributor
|
Thanks for raising the question. However, I don't think the suggested change makes anything clearer. There are a number of conventions and style recommendations which may mean going down a rabbit hole. Any alternative formulation, anyone? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks a lot for the great learning materials. I have one suggestion. Within the Tutorial Plotting and Programming in Python in the Variable and Assignment part, I would change the sentence about upper and lower case naming conventions for variables. The original statement 'upper-case letters are the conventions ... so we use lower case' is ambiguous. I guess this was just mixed up, but if not this would need further explanation in my opinion.