k3s-registry: match the deployed file mode, fix the Docker play - #379
Merged
Conversation
Follow-up to #378, from running --check against the full fleet. mode 0600 -> 0644. Content matched on all four configured nodes; the only diff was the mode. Since the copy notifies "restart k3s", applying it would have rolled every node in the cluster to tighten permissions on a file that holds no credentials. If an auth block is ever added here, tighten it in that same commit and accept the restart then -- permissions are worth a restart when there is a secret to protect, and not before. The Docker play could not succeed and would have been harmful if it had. h4-core runs docker-ce 29.7.1, which depends on containerd.io; the task installed Ubuntu's docker.io, which depends on containerd, and the two conflict: containerd.io : Conflicts: containerd So the task failed every run, and had it succeeded it would have torn out a working Docker install. Now guarded by a docker --version probe. xu3-1 dropped from that play. It runs Ubuntu 16.04, whose Python is too old for ansible-core: every module dies with a SyntaxError on an f-string inside module_utils/basic.py, before any task logic runs. ignore_unreachable does not help because the host is reachable -- the module is what breaks. It is already excluded from Ansible auto-updates; configure it by hand or retire it rather than having every run report a failure. opi5pro-1 has been brought into line separately: file created, k3s-agent restarted, nothing else touched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #378, from running --check against the full fleet.
mode 0600 -> 0644. Content matched on all four configured nodes; the only diff
was the mode. Since the copy notifies "restart k3s", applying it would have
rolled every node in the cluster to tighten permissions on a file that holds no
credentials. If an auth block is ever added here, tighten it in that same commit
and accept the restart then -- permissions are worth a restart when there is a
secret to protect, and not before.
The Docker play could not succeed and would have been harmful if it had. h4-core
runs docker-ce 29.7.1, which depends on containerd.io; the task installed
Ubuntu's docker.io, which depends on containerd, and the two conflict:
containerd.io : Conflicts: containerd
So the task failed every run, and had it succeeded it would have torn out a
working Docker install. Now guarded by a docker --version probe.
xu3-1 dropped from that play. It runs Ubuntu 16.04, whose Python is too old for
ansible-core: every module dies with a SyntaxError on an f-string inside
module_utils/basic.py, before any task logic runs. ignore_unreachable does not
help because the host is reachable -- the module is what breaks. It is already
excluded from Ansible auto-updates; configure it by hand or retire it rather than
having every run report a failure.
opi5pro-1 has been brought into line separately: file created, k3s-agent
restarted, nothing else touched.