Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a few breaking changes in the gimli 0.33.0 release, and I've done this update to see what impact they had here. Most of these changes are straightforward. but a couple are notable.
UnitSectionOffsetis no longer an enum. I've replaced all of its uses withDebugInfoOffset, since the code already didn't handle .debug_types, and it's unlikely it will ever need to.next_dfsno longer returns the change in depth. The depth is now available fromDebuggingInformationEntry::depth. However, it looks like the previous code was wrong: it treated the returned value as a depth, not a change in depth. So there may be a noticeable change in behaviour here which you may want to verify works as expected.My own testing has been simply to check that CI passes.