feat: explain value display failures and capture limits - #304
Merged
Conversation
Expose stable value diagnostics in printed values and trace details so users can distinguish unavailable variables, failed reads, adapter fallbacks, and capture limits. Preserve path-qualified notes in CLI and TUI output independently of capture selection and register locations. Embed --value-diagnostics-help, provide matching English and Chinese guidance, and update the runtime-analysis skill to 0.0.6. Explain failed read triage without treating errno or static display limits as a cause. Consolidate diagnostic e2e coverage around reasons, retained values, streams, and exit status, including ordinary null-pointer reads and register-backed arguments with static display notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust values that fall back to internal fields or contain missing data need an explanation at the point of use. This change adds consistent value markers and trace details for unavailable variables, failed memory reads, unsupported semantic layouts or read plans, and capture limits. Successfully captured fields remain visible.
--no-log --no-status; TUI users can inspect them withinfo trace.--value-diagnostics-helpguide, matching English and Chinese documentation, README links, and runtime-analysis skill version 0.0.6. Explain why errno alone cannot distinguish a page that cannot be faulted in from an invalid address, when--sleepable-uprobemay help and its performance cost, and when an incorrect computed address indicates a GhostScope bug.Validation completed on the final code tree:
cargo fmt --allcargo clippy --all-targets --all-features -- -D warningscargo clippy -p ghostscope-e2e-tests --test value_diagnostics_execution --all-features -- -D warningscargo test -p ghostscope-dwarf -p ghostscope-compiler -p ghostscope-protocol --lib --all-features: 585 tests passed.cargo test -p ghostscope-e2e-tests --tests --all-features: 373 tests passed through the runner service with host tracing host targets, including all 14 diagnostic cases.