feat: add support for Positive, PositiveOrZero, Negative, and NegativeOrZero constraints in model validation#5044
Closed
NaMinhyeok wants to merge 1 commit intoswagger-api:masterfrom
Closed
Conversation
…eOrZero constraints in model validation
Merged
11 tasks
Collaborator
|
@NaMinhyeok after reviewing the current state of the codebase, we're closing this PR as the underlying logic has since been reworked and the approach here is no longer applicable to the current code. The fix has been implemented in #5162 Thank you so much for taking the time to look into this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #5035
Type of Change
Checklist
Screenshots / Additional Context