Fix typescript axios content type - #1428
Open
flashnoob wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The updated template block introduces avoidable maintainability issues (indentation inconsistency and unnecessary let) and the behavior change lacks regression test coverage for the TypeScript Axios generator.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the typescript-axios generator template to detect the Content-Type header in a case-insensitive way when deciding whether to JSON-serialize the request body.
Changes:
- Replaces the exact
headers['Content-Type']lookup with a case-insensitive scan oflocalVarRequestOptions.headers. - Refactors the request-body serialization block into a multi-line conditional for readability.
File summaries
| File | Description |
|---|---|
src/main/resources/handlebars/typescript-axios/apiInner.mustache |
Adjusts generated body-serialization logic to treat Content-Type header keys case-insensitively. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+209
to
+213
| Object.keys(localVarRequestOptions.headers || {}).some( | ||
| headerKey => | ||
| headerKey.toLowerCase() === "content-type" && | ||
| (localVarRequestOptions.headers as any)[headerKey] === "application/json" | ||
| ); |
Comment on lines
+206
to
+219
| {{#bodyParam}} | ||
| let needsSerialization = | ||
| typeof {{paramName}} !== "string" || | ||
| Object.keys(localVarRequestOptions.headers || {}).some( | ||
| headerKey => | ||
| headerKey.toLowerCase() === "content-type" && | ||
| (localVarRequestOptions.headers as any)[headerKey] === "application/json" | ||
| ); | ||
|
|
||
| localVarRequestOptions.data = | ||
| needsSerialization | ||
| ? JSON.stringify({{paramName}} !== undefined ? {{paramName}} : {}) | ||
| : ({{paramName}} || ""); | ||
| {{/bodyParam}} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fix case-insensitive
Content-Typedetection in thetypescript-axiosgenerator.The generated client currently checks the
Content-Typeheader using an exact key: