Conversation
No need to re-import datetime as datetime_lib inside __init__, just import it as that in the outer scope once. Import the typing members directly.
tasn
left a comment
There was a problem hiding this comment.
Hey @ericbn, thanks for the contributions! These changes are unfortunately very subjective, and they are different to our stylistic choices at Svix. We follow the t for typing and prefer not to rename when importing. So the previous version is more suitable for us.
Hi @tasn. I sure can revert the changes in the typing import. Regarding not renaming, you're already doing EDIT: Just reverted the changes to the typing import. |
|
Cool, for your consideration this could be a good fit to still further refactor the existing code: https://adamj.eu/tech/2019/09/12/how-i-import-pythons-datetime-module/ It's even mentioned and suggested in https://docs.python.org/3/library/datetime.html |
No need to re-import datetime as datetime_lib inside
__init__, just import it as that in the outer scope once.Import the typing members directly.