fix(tools): support multi-part and array message content in OpenAI middleware - #1638
Open
Adityakk9031 wants to merge 1 commit into
Open
fix(tools): support multi-part and array message content in OpenAI middleware#1638Adityakk9031 wants to merge 1 commit into
Adityakk9031 wants to merge 1 commit into
Conversation
Contributor
Author
|
Hey @Dhravya @MaheshtheDev, could you please take a look at this fix when you have a chance? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
packages/tools/src/openai/middleware.ts,getLastUserMessageandgetConversationContentpreviously assumed messagecontentwas strictly astring.When callers use modern OpenAI multimodal or multi-part messages where
contentis an array of content parts ([{ type: "text", text: "..." }, ...]),typeof content === "string"evaluated tofalse, causinggetLastUserMessageto return"".In
createWithMemory,!userMessageevaluated totrue, which caused the middleware to:Solution
extractMessageTextinopenai/middleware.tsto cleanly extract and join text parts from both string content and array content parts (ChatCompletionContentPartText).getLastUserMessageandgetConversationContentto useextractMessageText.packages/tools/src/openai-middleware.test.tscovering string, multi-part, and multimodal inputs.Verification
Ran
bun test packages/tools/src/openai-middleware.test.ts(all 6 tests passed).