fix(validation): remove unreachable limit refine branches in search schemas - #1622
Open
ygd58 wants to merge 1 commit into
Open
fix(validation): remove unreachable limit refine branches in search schemas#1622ygd58 wants to merge 1 commit into
ygd58 wants to merge 1 commit into
Conversation
…chemas SearchRequestSchema and Searchv4RequestSchema both chain .positive().optional().default(10) before their limit refine, so by the time the refine runs the value can never be undefined (default() substitutes 10) and can never be <= 0 (positive() already rejects it). The v === undefined || (v > 0 && ...) guard was therefore dead code -- only the upper bound (v <= 100) check had any effect. Simplified both to just the meaningful check and added tests covering the default, the accepted range, and both still-rejected boundaries (0 and 101), plus a source-level guard extending the existing search-threshold dead-code check. No behavior change: same values are accepted/rejected before and after, confirmed by the added tests. Refs supermemoryai#1205
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SearchRequestSchema and Searchv4RequestSchema both chain
.positive().optional().default(10)before theirlimitrefine, so by the time the refine runs the value can never beundefined(default()substitutes 10) and can never be<= 0(positive()already rejects it). Thev === undefined || (v > 0 && ...)guard was therefore dead code — only the upper bound (v <= 100) check had any effect.Simplified both to just the meaningful check, and extended the existing source-level dead-code test (which already covered the threshold fields) plus added tests for the limit default, accepted range, and both still-rejected boundaries (0 and 101).
No behavior change — same values accepted/rejected before and after, confirmed by tests.
Refs #1205