Skip to content

fix(painter-dom): set default page text color#3648

Open
xy200303 wants to merge 2 commits into
superdoc-dev:mainfrom
xy200303:fix/page-default-text-color
Open

fix(painter-dom): set default page text color#3648
xy200303 wants to merge 2 commits into
superdoc-dev:mainfrom
xy200303:fix/page-default-text-color

Conversation

@xy200303
Copy link
Copy Markdown

@xy200303 xy200303 commented Jun 5, 2026

Summary

  • Give DomPainter pages an explicit default text color of var(--sd-layout-page-color, #000).
  • Allow consumers to override the page text color through pageStyles.color.
  • Add tests covering the default and override behavior so list markers and other content without explicit run color do not inherit a hostile host-app color.

Verification

  • pnpm test:all -- --root ./packages/layout-engine/painters/dom src/styles.test.ts
  • git diff --check
  • rg "@superdoc/(super-editor|style-engine|layout-bridge|layout-resolved)" packages/layout-engine/painters/dom/src -g '!*.test.ts' -g '!_test-utils.ts'
  • pnpm test:all -- --root ./packages/layout-engine/painters/dom src/paragraph/list-marker.test.ts src/renderer-marker-suffix.test.ts src/renderer-marker-textwidth.test.ts (fails during collection: current workspace cannot resolve @superdoc/font-system)
  • pnpm test:all -- --root ./packages/layout-engine/painters/dom src/index.test.ts -t "word-layout markers|resolved list" (fails during collection: current workspace cannot resolve @superdoc/font-system)

Closes #3456

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-numbered list markers render as white text (invisible) — .superdoc-page sets color: rgb(255,255,255)

2 participants