Skip to content

fix(super-editor): rethrow export docx errors#3641

Open
xy200303 wants to merge 2 commits into
superdoc-dev:mainfrom
xy200303:fix/export-docx-rethrow
Open

fix(super-editor): rethrow export docx errors#3641
xy200303 wants to merge 2 commits into
superdoc-dev:mainfrom
xy200303:fix/export-docx-rethrow

Conversation

@xy200303
Copy link
Copy Markdown

@xy200303 xy200303 commented Jun 5, 2026

Summary

  • Re-throw normalized Editor.exportDocx() errors after preserving the existing exception event and console logging.
  • Remove undefined from the internal implementation return union.
  • Add a regression test that verifies failed converter.exportToDocx calls reject to the caller.

Verification

  • pnpm test:editor -- src/editors/v1/tests/export/exportDocx.errors.test.js
  • pnpm test:editor -- src/editors/v1/tests/export/exportDocx.errors.test.js src/editors/v1/tests/export/exportDocx.commentsFallback.test.js
  • pnpm --prefix packages/super-editor run types:check (fails: existing unresolved @superdoc/font-system declarations and broad pre-existing JS/TS errors)

Closes #3579

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editor.exportDocx() swallows export errors — catch returns undefined instead of rethrowing

2 participants