chore: migrate pure packages to bun test runner#1896
chore: migrate pure packages to bun test runner#1896caio-pizzol wants to merge 2 commits intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74cfefd1fa
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "devDependencies": { | ||
| "typescript": "catalog:", | ||
| "vitest": "catalog:" | ||
| "typescript": "catalog:" | ||
| } |
There was a problem hiding this comment.
Removing vitest from @superdoc/style-engine breaks pnpm build/tsc --project tsconfig.json --noEmit because src/bench/resolveSdtMetadata.bench.ts still imports bench from vitest and tsconfig.json includes all src/**/*. In this package, that means TypeScript can no longer resolve the module during builds (even if tests run under Bun), so the migration leaves the package unable to typecheck unless vitest is restored or the bench file is excluded.
Useful? React with 👍 / 👎.
caio-pizzol
force-pushed
the
caio/sd-1704-improve-unit-test-performance-migrate-pure-logic-packages
branch
from
74cfefd to
0adea7f
Compare
1 participant
No description provided.