Skip to content

fix: add acceptance test to ensure cache access isolation#1244

Open
itslenny wants to merge 2 commits into
masterfrom
lenny/acceptance-test-fixes-cdn-cache-auth-check
Open

fix: add acceptance test to ensure cache access isolation#1244
itslenny wants to merge 2 commits into
masterfrom
lenny/acceptance-test-fixes-cdn-cache-auth-check

Conversation

@itslenny

@itslenny itslenny commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Add acceptance check to ensure private accesses are not available via public endpoint.

@itslenny
itslenny requested a review from a team as a code owner July 17, 2026 20:08
@coveralls

coveralls commented Jul 17, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 29852916008

Coverage increased (+20.7%) to 79.785%

Details

  • Coverage increased (+20.7%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 12786
Covered Lines: 10648
Line Coverage: 83.28%
Relevant Branches: 7476
Covered Branches: 5518
Branch Coverage: 73.81%
Branches in Coverage %: Yes
Coverage Strength: 432.2 hits per line

💛 - Coveralls

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to merge — the two nits flagged inline (potential testTimeout margin from the higher CACHE_RETRIES, and the new BYPASS check's retries masking transient leaks) are test-only and don't block this PR.

Extended reasoning...

Overview

This PR only touches acceptance/specs/cdn.test.ts: it raises SIGNED_EXPIRES_IN_S and CACHE_RETRIES to reduce acceptance-test flakiness, replaces a conditional webhook pause with a fixed 5s delay in the transform-caching test, and adds a new regression check that a private/authenticated object's transform cannot be served through the public route/cache.

Security risks

None — this is acceptance-test code only, no production source is changed. The new check is itself a security-relevant test (verifying no cross-tenant/cross-bucket cache leak via the public route), which is a good addition in principle.

Level of scrutiny

Low-to-moderate. Test-only diff, no risk to production behavior; worst case is test flakiness or a masked regression check, both non-destructive and already called out in the inline nits.

Other factors

Both findings from the bug-hunting pass are correctly scoped as nits: the timeout-margin issue is probabilistic and only manifests under degraded conditions, and the retry-masking issue only hides a transient (self-correcting) leak — a persistent leak would still be caught. The one other candidate issue raised (unconditional 5s delay for non-signed methods) was reviewed and ruled out as not a real bug. Given the low blast radius of test-only changes, these nits don't warrant blocking merge.

Comment thread acceptance/specs/cdn.test.ts
Comment thread acceptance/specs/cdn.test.ts
@itslenny
itslenny force-pushed the lenny/acceptance-test-fixes-cdn-cache-auth-check branch 2 times, most recently from a6185bd to 8739287 Compare July 17, 2026 21:59
Comment thread acceptance/specs/cdn.test.ts
@itslenny
itslenny force-pushed the lenny/acceptance-test-fixes-cdn-cache-auth-check branch from 8739287 to 244d5c0 Compare July 21, 2026 16:32
@itslenny
itslenny requested a review from ferhatelmas July 21, 2026 17:38
@itslenny itslenny changed the title fix: adjust acceptance test time and add extra cache check fix: add acceptance test to ensure cache access isolation Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants