Skip to content

chore: remove nixConfig from flake.nix #2308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brainrake wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

chore: remove nixConfig from flake.nix #2308

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cd611c
chore: remove nixConfig from flake.nix
brainrake Jul 23, 2026
1e936cf
Merge branch 'develop' into marton/remove-nixconfig-flake
brainrake Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
{
description = "Prototype tooling for deploying PostgreSQL";
nixConfig = {
# Skip rebuilding all the packages, download instead.
# See nix/docs/binary-cache.nix to set it up.
Comment on lines -4 to -5

@mmlb mmlb Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to keep the comment, it makes sense to have the doc pointer here since its pretty likely to have someone read the flake at some point.

Maybe we do:

Suggested change
# Skip rebuilding all the packages, download instead.
# See nix/docs/binary-cache.nix to set it up.
# Skip rebuilding all the packages, download instead.
# See nix/docs/binary-cache.nix to set it up.
# nixConfig.extra-substituters = [ "https://nix-postgres-artifacts.s3.amazonaws.com" ];
# nixConfig.extra-trusted-public-keys = [ "nix-postgres-artifacts:dGZlQOvKcNEjvT7QEAJbcV6b6uk7VF/hWMjhYleiaLI=" ];

extra-substituters = [ "https://nix-postgres-artifacts.s3.amazonaws.com" ];
};
inputs = {
devshell.url = "github:numtide/devshell";
devshell.inputs.nixpkgs.follows = "nixpkgs";
Expand Down
Loading