[codex] Add AMI config precedence smoke test#2178
Open
jgoux wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds an AMI-level testinfra regression test that verifies CLI-managed PostgreSQL overrides in
/etc/postgresql-custom/custom-overrides.conftake precedence over generated optimizations in/etc/postgresql-custom/conf.d/generated-optimizations.confafter PostgreSQL restarts.The test writes conflicting
max_connectionsvalues, restarts PostgreSQL, and assertspg_settingsreports the value and source file fromcustom-overrides.conf. It backs up and restores the touched config files so later AMI tests are not left with mutated state.Why
A hosted AMI incident showed generated optimization config could override CLI-managed Postgres config changes. This smoke test captures that precedence contract at the AMI layer, where the regression occurred, without coupling the test to the CLI or Admin API.
Validation
python3 -m py_compile testinfra/test_ami_nix.pygit diff --checkI also attempted
nix develop --accept-flake-config -c python -m pytest --collect-only testinfra/test_ami_nix.py, but the dev shell failed while fetchingcrate-cbitset-0.2.0.tar.gzfrom crates.io due SSL/403 download errors before pytest collection could run.