fix: parse column checks with pg_get_expr instead of substring - #1145
Open
hsusul wants to merge 1 commit into
Open
fix: parse column checks with pg_get_expr instead of substring#1145hsusul wants to merge 1 commit into
hsusul wants to merge 1 commit into
Conversation
NOT VALID and NO INHERIT suffixes made the old CHECK (...) length heuristic return a corrupted expression into the columns API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NOT VALID/NO INHERITsuffixes corrupted columncheckvia the oldpg_get_constraintdeflength-8 heuristic.pg_get_expr(conbin, conrelid)and strip one outer paren pair so the API still returnsid > 0(not(id > 0)).Test plan
npx vitest run test/index.test.ts -t "column check with NOT VALID|column check with NO INHERIT|column with multiple checks|dropping column checks"NOT VALID