fix: quote function config_params values in CREATE FUNCTION SET - #1144
Open
hsusul wants to merge 1 commit into
Open
fix: quote function config_params values in CREATE FUNCTION SET#1144hsusul wants to merge 1 commit into
hsusul wants to merge 1 commit into
Conversation
Unquoted values like statement_timeout TO 5s are invalid SQL. Quote GUC values (and list items such as search_path) the same way roles do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SET statement_timeout TO 5s(and similar) fromfunctions.create/ regenerate-on-update is invalid SQL.literal(), split list GUCs likesearch_pathinto individually quoted items, andident()the parameter name — aligned with role config quoting.FROM CURRENTcheck (value[0] === 'FROM CURRENT'compared the first character, so it never matched).Test plan
npx vitest run test/index.test.ts -t "create function with statement_timeout|retrieve, create, update, delete"statement_timeout = 5sconfig