fix: quote check constraint names when dropping via column update - #1141
Open
hsusul wants to merge 1 commit into
Open
fix: quote check constraint names when dropping via column update#1141hsusul wants to merge 1 commit into
hsusul wants to merge 1 commit into
Conversation
Hyphenated or otherwise non-plain check names need %I; %s produced invalid DROP CONSTRAINT SQL on PATCH /columns when clearing checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
columns.updateusedDROP CONSTRAINT %s, which breaks for hyphenated or otherwise non-plain constraint names (e.g."t-c-check").%Iso names are identifier-quoted, consistent with unique-constraint drops in the same path.Test plan
npx vitest run test/index.test.ts -t "dropping hyphenated column check|dropping column checks"