fix: scope pg_indexes join by schemaname - #1138
Open
hsusul wants to merge 1 commit into
Open
Conversation
Index names are unique per schema, not globally. Joining pg_indexes only on indexname produced duplicate rows with another schema's index_definition whenever two schemas shared the same primary-key or index name. Closes supabase#1136
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pg_indexeson both index name andschemaname, so each index OID maps to exactly oneindex_definitionusers_pkey)Closes #1136
Independent of #1108 / #1109 (attribute/
indkeymatching).Test plan
dup_idx_pkey→ one private row whose definition referencesprivate.dup_idx, notpublic.dup_idxlist indexes/retrieve indextests still pass