chore: Add additional path to auth-v1-open-callback#5089
Open
barrownicholas wants to merge 1 commit intosupabase:developfrom
Open
chore: Add additional path to auth-v1-open-callback#5089barrownicholas wants to merge 1 commit intosupabase:developfrom
barrownicholas wants to merge 1 commit intosupabase:developfrom
Conversation
Author
|
@avallete @sweatybridge could you check this out when you have a second? Thank you!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
signInWithOAuthcustom provider incorrectredirect_uriauth#2477signInWithOAuthcustom provider incorrectredirect_uriauth#2477 (comment))What is the current behavior?
In the new custom OIDC/OAuth provider, it hard-codes the redirect URI to {{KONG-GATEWAY}}
/callback. Since Auth/GoTrue can be self-hosted, and not necessarily behind Kong, at/auth/v1, it seems like the callback cannot be modified in Auth/GoTrue (instead, in Kong, (see supabase/auth#2477 (comment))).What is the new behavior?
The new behavior properly proxies
/callbackand/auth/v1/callbackto GoTrue.Additional context
See the issue linked above (supabase/auth#2477)
Basically, the below line of code cannot change:
https://github.com/supabase/auth/blob/2d8f2b6168cfc753f55c7bd157bfda6ef05af007/internal/api/external.go#L682
Instead, Kong needs to properly proxy
/callbackin the same way that it ports/auth/v1/callback