Skip to content

fix(pg-delta): declarative-sync-no-declarative-dir-set#5078

Merged
avallete merged 2 commits intodevelopfrom
fix/declarative-sync-no-declarative-dir-set
Apr 14, 2026
Merged

fix(pg-delta): declarative-sync-no-declarative-dir-set#5078
avallete merged 2 commits intodevelopfrom
fix/declarative-sync-no-declarative-dir-set

Conversation

@avallete
Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

  • Fix a DSL issue with pg-delta upgrade
  • Fix an issue where config schema_path was added when using the pg-delta branch.

… is enabled

- These tests verify that the configuration remains unchanged when PgDelta is enabled, ensuring the declarative directory is the source of truth.
- Updated the WriteDeclarativeSchemas function to reflect the new behavior regarding PgDelta configuration.
@avallete avallete requested a review from a team as a code owner April 13, 2026 18:19
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 24359587201

Coverage decreased (-0.008%) to 63.751%

Details

  • Coverage decreased (-0.008%) from the base build.
  • Patch coverage: 1 of 1 lines across 1 file are fully covered (100%).
  • 5 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

5 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
internal/utils/git.go 5 57.14%

Coverage Stats

Coverage Status
Relevant Lines: 15363
Covered Lines: 9794
Line Coverage: 63.75%
Coverage Strength: 7.02 hits per line

💛 - Coveralls

@avallete avallete enabled auto-merge (squash) April 13, 2026 18:38
@avallete avallete merged commit 90be78a into develop Apr 14, 2026
10 checks passed
@avallete avallete deleted the fix/declarative-sync-no-declarative-dir-set branch April 14, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants