fix: support secp256k1 elliptic curve for telegram OIDC#2548
Open
Jualhosting wants to merge 2 commits into
Open
fix: support secp256k1 elliptic curve for telegram OIDC#2548Jualhosting wants to merge 2 commits into
Jualhosting wants to merge 2 commits into
Conversation
Resolves supabase#2534 by adding a fallback mechanism in ParseIDToken. When go-jose throws unsupported elliptic curve error, the fallback manually fetches the JWKS and verifies the secp256k1 signature using go-ethereum/golang-jwt ECDSA implementation.
![depthfirst-app[bot]](https://avatars.githubusercontent.com/in/1021002?s=60&v=4){kind=small}
Author
|
Thank you for the excellent automated security scan findings! I have successfully addressed both the SSRF and OIDC token issuer verification bypass vulnerabilities in the latest commit:
The PR is updated, fully secure, and ready for review! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Resolves #2534
When attempting to use Telegram OIDC or any Custom OAuth provider that uses the
secp256k1elliptic curve in their JWKS, the authentication flow fails. The underlyinggo-joselibrary does not supportsecp256k1, leading to a failure when attempting to fetch and verify the identity token signature.What is the new behavior?
This PR introduces a fallback mechanism in
ParseIDToken. Whenverifier.Verify()fails due to an "unsupported elliptic curve" error, the fallback logic:secp256k1EC key.crypto/ecdsapackage andgolang-jwt/jwt, powered bydecred/dcrd/dcrec/secp256k1(which is already a dependency).*oidc.IDTokenstruct for downstream compatibility.This allows Telegram OIDC to work out of the box without requiring forks of
go-oidcorgo-jose.Assistance Disclosure
I used Antigravity (a Gemini-based AI coding assistant) to help write the boilerplate and crypto logic for this secp256k1 OIDC support. I have manually verified the implementation and added tests to ensure correctness.