chore: stricter referrer check per rfc9700#2479
Open
staaldraad wants to merge 3 commits intomasterfrom
Open
Conversation
RFC9700 calls for strict URL validation, not just hostname: This means the authorization server MUST ensure that the two URIs are equal; see Section 6.2.1 of [RFC3986], Simple String Comparison, for details. The only exception is native apps using a localhost URI: In this case, the authorization server MUST allow variable port numbers as described in Section 7.3 of [RFC8252].
This comment has been minimized.
This comment has been minimized.
staaldraad
force-pushed
the
chore/prodsec-89
branch
from
0293217 to
fbf58a3
Compare
staaldraad
force-pushed
the
chore/prodsec-89
branch
from
fbf58a3 to
66f0d51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
chore
What is the current behavior?
only the hostname is compared in the referrer check
What is the new behavior?
validates that the scheme and port also match
Additional context
Follows the rfc by having an exception for localhost