Skip to content

chore(ci): run tests in parallel against Oriole DB#2464

Open
fadymak wants to merge 3 commits intomasterfrom
fm/auth-1154-oriole-tests
Open

chore(ci): run tests in parallel against Oriole DB#2464
fadymak wants to merge 3 commits intomasterfrom
fm/auth-1154-oriole-tests

Conversation

@fadymak
Copy link
Copy Markdown
Contributor

@fadymak fadymak commented Apr 7, 2026

Run tests against Oriole DB in parallel

@fadymak fadymak requested a review from a team as a code owner April 7, 2026 07:17
@blacksmith-sh
Copy link
Copy Markdown

blacksmith-sh bot commented Apr 7, 2026

Found 4 test failures on Blacksmith runners:

Failures

Test View Logs
github.com/supabase/auth/internal/api/TestE2EHooks View Logs
github.com/supabase/auth/internal/api/TestVerify View Logs
github.com/supabase/auth/internal/api/TestVerify/
TestVeryEmailChangeSendsNotificationEmail
View Logs
github.com/supabase/auth/internal/api/TestWeb3 View Logs

Fix in Cursor

fadymak added a commit that referenced this pull request Apr 7, 2026
Test was relying on implicit ordering from Postgres. This assumption
does not necessarily hold under Oriole

Related: #2464
fadymak added a commit that referenced this pull request Apr 7, 2026
…ngines (#2465)

Returns identities in a consistent order to work across DB engines.

Previously, we were relying on Postgres' implicit ordering which is
considered an implementation detail and does not carry across to Oriole
DB
(https://github.com/supabase/auth/actions/runs/24069608972/job/70203207256?pr=2464).

Although we don't have an index on created_at, this should be fine since
a user is unlikely to have many indexes and `FindProvidersByUser`
filters by the user_id first.

Related: #2464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants