Fix: Remove event listeners in destroy() method #4906
+4
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4901
Problem
Widget windows add three event listeners to
documentwhen created (mouseup,mousemove,mousedown) but these listeners are never removed when the widget is closed.The cleanup code exists in the
close()method, but all 20 widgets in the codebase overrideonclose()and calldestroy()directly, so the cleanup code never runs.This causes a memory leak where every widget open/close cycle leaves 3 orphaned event listeners attached to
document. In longer sessions, this leads to degraded performance as hundreds of unused listeners accumulate.Solution
Moved the
removeEventListenercalls fromclose()todestroy()so cleanup happens regardless of which method is called.Testing
Before

After
