feat(isthmus): add PostgreSQL TPC-H integration testing#700
feat(isthmus): add PostgreSQL TPC-H integration testing#700nielspardon wants to merge 2 commits intosubstrait-io:mainfrom
Conversation
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
|
I am working on a fuller response here, but just wanted to see if you were aware of the existence of this related-seeming repository? |
I am aware of the repo. The problem with the consumer-testing repo is that by design it is a centralized approach and hence difficult to maintain. There is currently no active maintenance of it. I would suggest to not do the consumer testing centrally but to provide a Substrait testkit that integrations can test against in a decentralized setup. This brings the testing closer to the code being tested allowing for shorter cycles. This e.g. what a project like dbt does with their many adapters. @andrew-coleman has been looking into updating the consumer-testing repo to a more recent spec version and it led him down a rabbit hole of many of the currently tested consumers not having updated to the latest spec version. In some cases ending up with seemingly unmaintained consumers like e.g. Apache Ibis. |
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
This PR adds integration testing for isthmus against a PostgreSQL database.
*.tblfiles*.tblfilesqueriessubfolder e.g.interval '1 day'instead ofinterval '1' day(3).This is currently a draft since I want to get some early feedback. What I'm still planning to do: