style: add final modifier where possible#629
Open
nielspardon wants to merge 1 commit intosubstrait-io:mainfrom
Open
style: add final modifier where possible#629nielspardon wants to merge 1 commit intosubstrait-io:mainfrom
nielspardon wants to merge 1 commit intosubstrait-io:mainfrom
Conversation
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
nielspardon
requested review from
andrew-coleman,
benbellick,
bestbeforetoday and
vbarua
benbellick
requested changes
Dec 3, 2025
| <rule ref="category/java/codestyle.xml/FieldDeclarationsShouldBeAtStartOfClass" /> | ||
| <rule ref="category/java/codestyle.xml/FinalParameterInAbstractMethod" /> | ||
| <rule ref="category/java/codestyle.xml/LocalVariableCouldBeFinal" /> | ||
| <rule ref="category/java/codestyle.xml/MethodArgumentCouldBeFinal" /> |
Member
There was a problem hiding this comment.
I am definitely in favor of the first two FinalParameterInAbstractMethod and LocalVariableCouldBeFinal, but I am less convinced about introducing MethodArgumentCouldBeFinal. It looks like a lot noise is introduced in this PR by bringing in that rule. Considering that usage of final doesn't actually prevent mutation of the object, just reassignment to a new object, it doesn't seem that useful.
We also already have the immutables library to protect against mutation for the classes for which that matters.
Happy to be convinced though if there is a compelling reason to switch to using final.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes parameters and local variables final if possible and adds corresponding PMD checks so any new parameters or local variables will be declared final if they could be final.