fix: NO ENGAGEMENT lists engagements only, not rendered dashboards - #22
Merged
Merged
Conversation
Co-Authored-By: Subash Natarajan <suboss87@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found while running a fresh-user end-to-end pass (init → scan → debrief → prep → doctor → dashboard → unbound dir). After
fde dashboardrenders~/fde-engagements/fieldbook-current.html, runningfde resumefrom an unbound workspace advertised that HTML file as an existing client:cmdResume's unbound branch listed rawreaddirSyncentries filtered only on.-prefix, unlikecmdStatus/gatherEngagements, which both require a<dir>/.fde. Applied the same guard (plus.sort()for stable output), so only real engagements are offered as bind targets.New test asserts the list after a dashboard render is exactly
existing: clientaand contains nofieldbook-current.html. 73/73 tests + all 45bin/check.jsgates pass.Link to Devin session: https://app.devin.ai/sessions/f135381c4682413bae73dff38eb6d1a3
Requested by: @suboss87