Skip to content

[WIP] Fix the HLLC scheme on moving grids and its Jacobians #2943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rois1995 wants to merge 4 commits into
base: fix_underrelaxation_factor
Choose a base branch
from
Draft

[WIP] Fix the HLLC scheme on moving grids and its Jacobians #2943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a59d827
Compute HLLC on moving grids in the frame of the face, fix its Jacobians
Sep 29, 2026
e323f4c
Merge fix_underrelaxation_factor into fix_hllc_moving_grids
Oct 9, 2026
d2701a8
Merge remote-tracking branch 'origin/fix_underrelaxation_factor' into…
Oct 12, 2026
4960dd0
Fix HLLC supersonic Jacobians for reconstructed face enthalpy
Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Common/src/CConfig.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2176,7 +2176,7 @@ void CConfig::SetConfig_Options() {
addDoubleArrayOption("JST_SENSOR_COEFF", 2, false, jst_coeff);
/*!\brief LAX_SENSOR_COEFF \n DESCRIPTION: 1st order artificial dissipation coefficients for the Lax-Friedrichs method. \ingroup Config*/
addDoubleOption("LAX_SENSOR_COEFF", Kappa_1st_Flow, 0.15);
/*!\brief USE_ACCURATE_FLUX_JACOBIANS \n DESCRIPTION: Use numerically computed Jacobians for AUSM+up(2) and SLAU(2) \ingroup Config*/
/*!\brief USE_ACCURATE_FLUX_JACOBIANS \n DESCRIPTION: Use numerically computed Jacobians for AUSM+up(2) and SLAU(2), exact Jacobians (for fixed wave speeds) for HLLC \ingroup Config*/

@joshkellyjak joshkellyjak Oct 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the two behaviours here for AUSM/SLAU and HLLC, I think it would be better to split these into two separate options.

addBoolOption("USE_ACCURATE_FLUX_JACOBIANS", Use_Accurate_Jacobians, false);
/*!\brief CENTRAL_JACOBIAN_FIX_FACTOR \n DESCRIPTION: Improve the numerical properties (diagonal dominance) of the global Jacobian matrix, 3 to 4 is "optimum" (central schemes) \ingroup Config*/
addDoubleOption("CENTRAL_JACOBIAN_FIX_FACTOR", Cent_Jac_Fix_Factor, 4.0);
Expand Down
30 changes: 30 additions & 0 deletions SU2_CFD/include/numerics/flow/convection/hllc.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
class CUpwHLLC_Flow final : public CNumerics {
private:
bool implicit, dynamic_grid;
bool useAccurateJacobian; /*!< \brief Jacobians computed exactly for fixed wave speeds (USE_ACCURATE_FLUX_JACOBIANS). */
unsigned short iDim, jDim, iVar, jVar;

su2double *IntermediateState;
Expand All @@ -55,6 +56,8 @@ class CUpwHLLC_Flow final : public CNumerics {
su2double *dSm_dU, *dPI_dU, *drhoStar_dU, *dpStar_dU, *dEStar_dU;

su2double* Flux; /*!< \brief The flux accross the face. */
bool fixedWaveSpeeds = false; /*!< \brief Use fixed_sL, fixed_sR as wave speeds (verification of the Jacobians). */
su2double fixed_sL = 0.0, fixed_sR = 0.0;
su2double** Jacobian_i; /*!< \brief The Jacobian w.r.t. point i after computation. */
su2double** Jacobian_j; /*!< \brief The Jacobian w.r.t. point j after computation. */

Expand All @@ -79,6 +82,18 @@ class CUpwHLLC_Flow final : public CNumerics {
*/
ResidualType<> ComputeResidual(const CConfig* config) override;

/*!
* \brief Fix the left and right wave speeds (relative to the face), for the verification of the Jacobians, which
* treat them as constants.
* \param[in] active - Use the fixed values.
* \param[in] val_sL, val_sR - Left and right wave speeds.
*/
inline void SetFixedWaveSpeeds(bool active, su2double val_sL, su2double val_sR) {

@joshkellyjak joshkellyjak Oct 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these are only used for the unit test they should not be in the public API

fixedWaveSpeeds = active;
fixed_sL = val_sL;
fixed_sR = val_sR;
}

};

/*!
Expand All @@ -91,6 +106,7 @@ class CUpwHLLC_Flow final : public CNumerics {
class CUpwGeneralHLLC_Flow final : public CNumerics {
private:
bool implicit, dynamic_grid;
bool useAccurateJacobian; /*!< \brief Jacobians computed exactly for fixed wave speeds (USE_ACCURATE_FLUX_JACOBIANS). */
unsigned short iDim, jDim, iVar, jVar;

su2double *IntermediateState;
Expand All @@ -108,6 +124,8 @@ class CUpwGeneralHLLC_Flow final : public CNumerics {
su2double *dSm_dU, *dPI_dU, *drhoStar_dU, *dpStar_dU, *dEStar_dU;

su2double* Flux; /*!< \brief The flux accross the face. */
bool fixedWaveSpeeds = false; /*!< \brief Use fixed_sL, fixed_sR as wave speeds (verification of the Jacobians). */
su2double fixed_sL = 0.0, fixed_sR = 0.0;
su2double** Jacobian_i; /*!< \brief The Jacobian w.r.t. point i after computation. */
su2double** Jacobian_j; /*!< \brief The Jacobian w.r.t. point j after computation. */

Expand All @@ -132,6 +150,18 @@ class CUpwGeneralHLLC_Flow final : public CNumerics {
*/
ResidualType<> ComputeResidual(const CConfig* config) override;

/*!
* \brief Fix the left and right wave speeds (relative to the face), for the verification of the Jacobians, which
* treat them as constants.
* \param[in] active - Use the fixed values.
* \param[in] val_sL, val_sR - Left and right wave speeds.
*/
inline void SetFixedWaveSpeeds(bool active, su2double val_sL, su2double val_sR) {
fixedWaveSpeeds = active;
fixed_sL = val_sL;
fixed_sR = val_sR;
}

/*!
* \brief Compute the Average quantities for a general fluid flux between two nodes i and j.
* Using the approach of Vinokur and Montagne'
Expand Down
Loading
Loading