fix(SU2_CFD, Common): Fix physical correctness, robustness, and MDO compatibility#2669
Closed
shbhmexe wants to merge 7 commits intosu2code:developfrom
Closed
fix(SU2_CFD, Common): Fix physical correctness, robustness, and MDO compatibility#2669shbhmexe wants to merge 7 commits intosu2code:developfrom
shbhmexe wants to merge 7 commits intosu2code:developfrom
Conversation
added 2 commits
January 1, 2026 13:23
This commit addresses several issues in the SU2 codebase: 1. Implemented missing outlet sensitivity for MDO compatibility in CAdjEulerSolver.cpp. 2. Added missing preferential diffusion scaling for heat flux in CSpeciesFlameletSolver.cpp. 3. Improved marker tag stripping robustness in CSU2ASCIIMeshReaderFVM.cpp. 4. Added missing MPI communications to SetGridVel_Gradient in CSolver.cpp. 5. Adjusted spacing and formatting to align with SU2 style (Google based). Signed-off-by: shbhmexe <shubhushukla586@gmail.com>
bigfooted
reviewed
Jan 1, 2026
added 5 commits
January 1, 2026 22:39
Signed-off-by: shbhmexe <shubhushukla586@gmail.com>
Signed-off-by: shbhmexe <shubhushukla586@gmail.com>
Author
|
? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR addresses several impact-focused bug fixes and physical enhancements in the SU2 solver across the CFD and Common modules. The modifications improve MDO adjoint sensitivities, ensure physical correctness in flamelet heat flux calculations, add necessary MPI synchronization for dynamic mesh gradients, and enhance mesh reader robustness.
Key Fixes:
CAdjEulerSolver.cppfor MDO compatibility.Beta_Enth_Thermalscaling to isothermal wall heat flux inCSpeciesFlameletSolver.cppwhen preferential diffusion is enabled.InitiateCommsandCompleteCommsforGRID_VELOCITYinSetGridVel_Gradient(CSolver.cpp) for partition consistency.std::remove_iffor marker tags inCSU2ASCIIMeshReaderFVM.cpp.Related Work
CMultiGridGeometry.cppandupdateHistoryMap.pyto maintain original logic.CSolver.cpp(e.g.,ITER=9) to ensure zero overlap with recent past commits.PR Checklist
blackfor Python and manual Google-style audit for C++).walkthrough.md.