Repository navigation
Make event models generic over literal names - #26
Merged
Merged
Conversation
Owner
Author
|
Scope clarification: this branch migrates concrete event models to |
strohganoff
force-pushed
the
refactor/generic-event-models
branch
from
November 9, 2026 19:44
c97b869 to
a227232
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
EventBasegeneric over event-name string literals so concrete event models declare their protocol names with bases such asEventBase[Literal["keyDown"]]and expose precise event types to handlers.Pydantic's generic metadata validates the event-name type arguments and records each model's event names. The event adapter uses those names to build its dynamic validation schema. The refactor also simplifies
EventBase, updates model discovery, and revises the affected tests and README example.Three event class headers stay on one line with
# fmt: skipbecause Python 3.10's source inspection in Pydantic fails to tokenize those generic bases when written across multiple lines.Validation: 194 tests passed on Python 3.10; mypy passed; Ruff format check passed for the changed files.