Conversation
tonyxiao
approved these changes
Mar 31, 2026
Collaborator
tonyxiao
left a comment
tonyxiao
left a comment
There was a problem hiding this comment.
Approve. The 3-way split (stripe-setup / stripe-webhook / stripe-worker) is the right move — the monolithic path router was fighting against Supabase's per-function deployment model.
A couple of small things for awareness:
apps/supabase/src/edge-functions/stripe-sync.tsis deployed asstripe-worker. The filename mismatch will confuse people — consider renaming the file tostripe-worker.tsin a follow-up, or adding a comment at the top.const VERSION = '0.1.0'instripe-setup.ts— is this used anywhere for schema comment tracking? If not, remove it; if yes, it needs a process to stay in sync with releases.console.errorremoval insrc-list-api.ts: 👍 those were noisy.denoImportsPluginrename + simplification inbuild.mjsis cleaner than before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Supabase-specific regressions from main: clean vault on install, use time-based limits for sync invocations, remove noisy error logs
Add supabase CLI command to apps/engine for managing Supabase deployments
Split the monolithic stripe-sync edge function into three separate functions: stripe-setup, stripe-sync, and stripe-webhook
How to test (optional)
Tested by hand by deploying to supabase