Potential fix for code scanning alert no. 16: Workflow does not contain permissions#205
Open
Potential fix for code scanning alert no. 16: Workflow does not contain permissions#205
Conversation
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/stripe/sync-engine/security/code-scanning/16
In general, the problem is fixed by explicitly declaring a
permissionsblock at the workflow or job level to constrain the automatically providedGITHUB_TOKEN. For a workflow that only needs to check out code and does not modify the repository on GitHub (no pushes, releases, PR writes, etc.), the minimal appropriate permissions are usuallycontents: read. This documents the intent and ensures the workflow remains least-privileged even if repository/organization defaults change.The single best fix here is to add a
permissionsblock at the top (root) level of.github/workflows/docker-image.yml, so that it applies to all jobs. We’ll setcontents: read, which is sufficient foractions/checkoutto read the repository. The Docker-related steps authenticate to Docker Hub via secrets and do not need broader GitHub API access. Concretely, in.github/workflows/docker-image.yml, insert:between the existing
name: Stripe Build Imageline and theon:block. No other changes, imports, or additions are needed.Suggested fixes powered by Copilot Autofix. Review carefully before merging.