fix: make Contains and collection helpers rune-safe for Unicode strings#1908
Open
HarshalPatel1972 wants to merge 3 commits into
Open
fix: make Contains and collection helpers rune-safe for Unicode strings#1908HarshalPatel1972 wants to merge 3 commits into
HarshalPatel1972 wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates string containment checks in assert.Contains to avoid matching invalid UTF-8 byte fragments that cross Unicode rune boundaries, and adds regression tests covering Unicode-heavy scenarios.
Changes:
- Replace
strings.Containswith a rune-based containment check for string inputs. - Add new helper
runeSliceContainsto compare contiguous rune sub-slices. - Add tests for Unicode behavior in
ContainsandElementsMatch.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| assert/assertions.go | Switch string containment to rune-based search and add runeSliceContains helper |
| assert/assertions_test.go | Add Unicode-focused tests for Contains and ElementsMatch |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
assert.Containsand underlying collection validation routines rune-safe to prevent false positives and out-of-bounds slicing bugs on multi-byte Unicode strings/emojis.Changes
runeSliceContains, a zero-dependency sliding window helper that evaluates[]runecollections to preserve character boundary integrity.containsElementforreflect.Stringvariants to convert target data into[]runeslices before executing structural matches.assert/assertions_test.go.Motivation
The previous implementation relied directly on
strings.Contains, which works exclusively on raw byte tracking. If a searched token matched a specific sequence of middle-bytes within a multi-byte Unicode rune or emoji, the assertion returned invalid positive outcomes or triggered index runtime panics.Related issues
Closes #1518