This repository was archived by the owner on Jan 24, 2024. It is now read-only.
[improvement] Use Direct ByteBuffers after upgrade to 2.8.x#1631
Open
eolivelli wants to merge 10 commits intostreamnative:masterfrom
Open
[improvement] Use Direct ByteBuffers after upgrade to 2.8.x#1631eolivelli wants to merge 10 commits intostreamnative:masterfrom
eolivelli wants to merge 10 commits intostreamnative:masterfrom
Conversation
eolivelli
requested review from
BewareMyPower and
Demogorgon314
as code owners
BewareMyPower
suggested changes
Dec 19, 2022
Collaborator
BewareMyPower
left a comment
BewareMyPower
left a comment
There was a problem hiding this comment.
The code itself LGTM. Please fix the code style.
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaCommandDecoder.java
Outdated
Show resolved
Hide resolved
eolivelli
force-pushed
the
impl/kafka-client-use-bytebuf
branch
from
8de0f49 to
8e40ffe
Compare
eolivelli
changed the title
Contributor
Author
|
@BewareMyPower @Demogorgon314 I have rebased and also applied a few more enhancement that we developed while running performance testing at very high rates (tens of millions of messages per second) |
Contributor
Author
|
some tests are failing, I will check them out later |
Codecov Report
@@ Coverage Diff @@
## master #1631 +/- ##
============================================
- Coverage 16.05% 16.02% -0.04%
Complexity 626 626
============================================
Files 165 165
Lines 12311 12338 +27
Branches 1128 1131 +3
============================================
Hits 1977 1977
- Misses 10171 10198 +27
Partials 163 163
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
With the upgrade to 2.8.0 we switched to use more heap and less DirectMemory.
Modifications
Use pooled Netty direct memory ByteBufs
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)