Fix Enhanced Broadcasting probe startup and explain quality fallbacks - #1778
Open
aleksandr-voitenko wants to merge 2 commits into
Open
aleksandr-voitenko wants to merge 2 commits into
aleksandr-voitenko wants to merge 2 commits into
Conversation
summeroff
approved these changes
Sep 18, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Fallback reasons can still be overwritten, and the fixed pre-start group-release lifecycle lacks regression coverage.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Fixes Enhanced Broadcasting probe startup and preserves quality-fallback explanations.
Changes:
- Releases encoder groups for standalone synthetic probes.
- Standardizes congestion thresholds and retains fallback reasons.
- Adds multitrack lifecycle and client-contract tests.
File summaries
| File | Description |
|---|---|
| source/auto-optimizer-enhanced-broadcasting-policy.hpp | Tracks fallback evidence and reason codes. |
| obs-studio-server/tests/test-osn-video-mix-lifecycle.cpp | Adds multitrack A/V lifecycle tests. |
| obs-studio-server/source/nodeobs_auto_optimizer.cpp | Updates probe startup, congestion handling, and recommendations. |
| obs-studio-client/tests/auto-optimizer-enhanced-broadcasting-policy-test.cpp | Tests fallback-reason policy. |
| obs-studio-client/tests/auto-optimizer-client-contract-test.cpp | Tests fallback-reason projection. |
| js/module.ts | Documents measurement reasons. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sandboxcoder
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enhanced Broadcasting probes could fail when testing a higher frame rate than the renderer. Successful lower-quality recommendations also hid earlier upload or performance problems.
Changes
How Has This Been Tested?
Automated and manual tests. Windows only.
Types of changes