[osn-filter] Remove obsolete/deprecated/disabled filters#1743
Open
sandboxcoder wants to merge 1 commit into
Open
[osn-filter] Remove obsolete/deprecated/disabled filters#1743sandboxcoder wants to merge 1 commit into
sandboxcoder wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the filter type enumeration returned by OSN to omit filters that OBS marks as deprecated, disabled, or obsolete, aligning OSN behavior with OBSBasic’s filter menu logic so Desktop can prefer _v2 filters.
Changes:
- Filtered
Filter::Typesresults by OBS source flags (deprecated/disabled/obsolete) before returning type IDs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* use logic similar to OBSBasicFilters::CreateAddFilterPopupMenu to remove obsolete filters
sandboxcoder
force-pushed
the
rno/versioned-filters
branch
from
c03033b to
3d58470
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OBSBasicFilters::CreateAddFilterPopupMenuto remove obsolete filtersMotivation and Context
Update OSN to discard obsolete filters.
How Has This Been Tested?
mask_filter_v2,color_filter_v2, etc are used (there is a pull request that will depend on this one).Types of changes
Checklist: