Exposed Load method to invoke synchronous loading of component#42
Open
TrinaChoudhury wants to merge 6 commits intostratiformltd:masterfrom
Open
Exposed Load method to invoke synchronous loading of component#42TrinaChoudhury wants to merge 6 commits intostratiformltd:masterfrom
TrinaChoudhury wants to merge 6 commits intostratiformltd:masterfrom
Conversation
|
cc: @tazsingh |
|
@tazsingh @gregberge - Please review the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@loadable/component provides 2 methods preload and load method to load components through code synchronously. While preload doesn't return promise, load does.
On the other hand, react-loadable exposes preload method that returns promise.
The PR exposes "load" method which internally handles both the loadable libraries.