Conversation
aqjune-aws
reviewed
Feb 17, 2026
Contributor
aqjune-aws
left a comment
aqjune-aws
left a comment
There was a problem hiding this comment.
The directory name 'old_expected' doesn't seem to convey much information other than it is old. What about expected-nonlaurel and expected-laurel?
keyboardDrummer
previously approved these changes
Feb 18, 2026
aqjune-aws
approved these changes
Feb 18, 2026
keyboardDrummer
approved these changes
Feb 18, 2026
shigoel
approved these changes
Feb 18, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 12, 2026
Change the `LocalVariable none` case to emit Core `init` without RHS (havoc) instead of `defaultExprForType`. Source language translators that need default values should add explicit initializers at the Laurel level. This is the correct semantics for Laurel as a verification IR: an uninitialized variable has no known value until assigned. The previous behavior (defaulting to 0/false/"") was introduced in #435 for Python→Laurel but doesn't generalize to other source languages (e.g., JS/TS where uninitialized means `undefined`, not 0). Enables a follow-up in #505 to switch constrained type uninitialized variables from witness injection + assert to assume. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. Co-authored-by: Shilpi Goel <shigoel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python -> Laurel translation.
This includes a new
TCoretype in Laurel to directly refer to Core types. For now the benchmarks don't work with CVC5.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.