Support modifies clauses #397
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyboardDrummer
force-pushed
the
modifiesClaues
branch
from
35ea24f to
938efc1
Compare
keyboardDrummer
force-pushed
the
modifiesClaues
branch
from
122c8f2 to
73bb97f
Compare
keyboardDrummer
force-pushed
the
modifiesClaues
branch
from
7b28966 to
72b81cb
Compare
atomb
previously approved these changes
Feb 13, 2026
| -- Pure field update returns the same type as the target | ||
| | .PureFieldUpdate target _ _ => computeExprType env types target | ||
| -- Calls — we don't track return types here, so fall back to TVoid | ||
| | .StaticCall _ _ => panic "Not supported StaticCall" |
Contributor
There was a problem hiding this comment.
Given that this function will always need the option to fail (if given an ill-typed input), I'd prefer to prepare for that by making this function return Except ErrorType HighTypeMd, instead of using panic. I'll leave it up to you to choose what ErrorType should be. It could be a string or something more structured.
Contributor
Author
There was a problem hiding this comment.
I was planning on having this function take a proof that every identifier is in the environment. Transforming that for the recursive calls is quite a bit of work though, so I'd rather not do that now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Map Composite (Field Box)where Box is a datatype that can hold different values. This way, the translation of Laurel remains executable. The previous Heap encoding relied on axioms.Testing