generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 611
feat(hooks): add retry mechanism for tool calls #1556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dbschmigelski
wants to merge
5
commits into
strands-agents:main
Choose a base branch
from
dbschmigelski:hook-retry-mechanism
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(hooks): add retry mechanism for tool calls #1556
dbschmigelski
wants to merge
5
commits into
strands-agents:main
from
dbschmigelski:hook-retry-mechanism
+395
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `retry` field to AfterToolCallEvent and BidiAfterToolCallEvent that allows hook callbacks to trigger tool re-execution. When set to True, the tool executor discards the current result and invokes the tool again. This provides the hook infrastructure needed for implementing custom retry strategies for tool failures, timeouts, or transient errors.
Add tests verifying: - AfterToolCallEvent.retry field is writable - Setting retry=True causes tool re-execution - Retry works with error results from @tool decorator - Retry works with exceptions from tool.stream - Max retries can be controlled by hook callback - Integration tests with real Agent using HookProvider
Keep the first PR focused on standard AfterToolCallEvent only. BidiAfterToolCallEvent.retry can be added in a follow-up if needed.
- ToolStreamEvents ARE emitted from discarded attempts - ToolResultEvent is NOT emitted for discarded attempts
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
zastrowm
reviewed
Jan 26, 2026
| agent, selected_tool, tool_use, invocation_state, result | ||
| ) | ||
| # Check if retry requested for unknown tool error | ||
| if getattr(after_event, "retry", False): |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason to use getattr?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a retry field to AfterToolCallEvent that allows hook callbacks to trigger tool re-execution. When
set to True, the tool executor discards the current result and invokes the tool again with the same
tool_use_id.
This provides the hook infrastructure needed for implementing custom retry strategies for tool
failures, timeouts, or transient errors.
Changes
Streaming behavior
When retry=True:
Callers consuming streamed events should be prepared to see intermediate events from discarded
attempts.
Related Issues
#1405
Documentation PR
Todo
Type of Change
New feature
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.