refactor(hci): replace uv_hrtime with std chrono and remove libuv dependency#10
Open
chuckweiss wants to merge 1 commit intostoprocent:mainfrom
Open
refactor(hci): replace uv_hrtime with std chrono and remove libuv dependency#10chuckweiss wants to merge 1 commit intostoprocent:mainfrom
chuckweiss wants to merge 1 commit intostoprocent:mainfrom
Conversation
Owner
|
@chuckweiss Hey! Thank you for PR. Can you please fix your commits according to the Angular convention (google semantic-release) |
chuckweiss
changed the title
Author
@stoprocent thank you for the quick response! Hopefully I got this right. Let me know if there's anything else :) |
chuckweiss
changed the title
chuckweiss
changed the title
Author
|
@stoprocent is there anything else this PR needs from you? It is good on my part |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was testing bleno with Deno and it seemed to work fine until it threw because it could not find
uv_hrtime. This is because Deno uses Tokio instead of libuv. This PR replaces the usage ofuv_hrtimewith std chrono.