(Towards #428) Implementation of the Fortran2008 intrinsics

[LonelyCat124]

I attempted to add the Fortran2008 intrinsic in an extensible and similar way to the current.

I couldn't name it Fortran2008_Intrinsic_Name as the stuff in the Fortran2008.init.py stuff breaks the Fortran2003 setup because it makes a new Name class for Fortran2003 which matches every string.

Ready for a review from @arporter or @sergisiso once I fix any formatiting issues.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.24%. Comparing base (ea5c601) to head (5a27f24).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #514   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files          88       89    +1     
  Lines       13866    13882   +16     
=======================================
+ Hits        12790    12806   +16     
  Misses       1076     1076           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sergisiso]

I triggered PSyclone CI with this, as it would be good to include it in the next release.

[LonelyCat124]

I triggered PSyclone CI with this, as it would be good to include it in the next release.

I think the good news is PSyclone should immediately support these new functions without changes as its not dependent on a type check with Intrinsic_Name, but only Fortran2003.Intrinsic_Function_Reference which contains the Intirnsic_Name (sub)class as a child.

[arporter]

Thanks @LonelyCat124. I have to confess that I can't figure out how this works - I thought I'd be able to trip it up but all my attempts failed :-) However, I do think that, to be consistent with the other F2008 support, we shouldn't end up with a parse tree with F08-specific nodes in it. i.e. it should be possible to have the F08 parser give Intrinsic_Name nodes, just like the F03 one does (but for a wider set of names).

There's also a bit of code style tidying to do.

[LonelyCat124]

@arporter Addressed as we discussed today - I didn't add "done" to the last comments as we discussed the changes in person but they should all be resolved.

[arporter]

Thanks Aidan, I like the new implementation - glad it worked out well. Just a little bit of tidying left. I'll fire off the PSyclone ITs with this version too.

[arporter]

As the two issues are purely about pylint, I'll take the liberty of fixing them.

[arporter]

I realised that we already had a test file for F2008 intrinsics so I've moved the new tests into there and removed the new test file that this PR was adding. As such, it's going to need a review from @sergisiso.

[arporter]

Ready for a look now @sergisiso, thanks :-)

[sergisiso]

@arporter @LonelyCat124 I launched the IT tests once again but if they pass this is ready to merge.

[sergisiso]

@arporter Everything was gree, so I will proceed to merge